On 11/18/2016 03:59 AM, Shawn Lin wrote: > Add rockchip serial flash controller driver > > Signed-off-by: Shawn Lin <shawn.lin at rock-chips.com> [...] > +static void rockchip_sfc_unregister_all(struct rockchip_sfc *sfc) > +{ > + int i; > + > + for (i = 0; i < sfc->num_chip; i++) > + mtd_device_unregister(&(sfc->flash[sfc->num_chip].nor.mtd)); ^^^^^^^^^^^^^ This will always unregister the same flash, no ? This cannot work. > +} [...] -- Best regards, Marek Vasut