Hi Caesar, On Wed, May 25, 2016 at 11:47:46AM +0800, Caesar Wang wrote: > From: Sascha Hauer <s.hauer at pengutronix.de> > > This patch implemnets .set_trips for device tree thermal zones. ^ implements > As the hardware-tracked trip points is supported by thermal core patch[0]. > > patch[0] > "thermal: Add support for hardware-tracked trip points". > > Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de> > Signed-off-by: Caesar Wang <wxt at rock-chips.com> > Cc: Zhang Rui <rui.zhang at intel.com> > Cc: Eduardo Valentin <edubezval at gmail.com> Other than that, it looks good to me. You can add my Reviewed-by: Javi Merino <javi.merino at arm.com>