Hi Andi, Am Mittwoch, 29. Juni 2016, 01:09:22 schrieb Andi Shyti: > > > RK2928_CLKSEL_CON(0), 14, 2, MFLAGS, 8, 5, DFLAGS), > > > > > > - GATE(ACLK_CPU, "aclk_cpu", "aclk_cpu_src", CLK_IGNORE_UNUSED, > > > + GATE(ACLK_CPU, "aclk_cpu", "aclk_cpu_src", > > > + CLK_IS_CRITICAL | CLK_IGNORE_UNUSED, > > > > - you'll never need both critical and ignore_unused > > Indeed I was unsure whether I should remove the > CLK_IGNORE_UNUSED, but then I decided to leave it because that's > basically what the driver is currently doing. Thanks! > > > Happens in some more cases below, but otherwise looks ok ... as written > > in the cover-letter I'm just still trying to make up my mind if it's > > worth waiting for the handoff mechanism. > > You mean something similar (*)? I actually mean https://lkml.org/lkml/2016/2/11/694 which received additional comments somewhere and Mike said he wanted to repost. Heiko