Hi Heiko, On 2016?06?21? 17:43, Heiko St?bner wrote: > devicetree names are normally expected to be real, aka no "x" as catchall. So > I guess either just add compatibles for both the rk3228 and rk3229 which point > to the same structure in the driver. (So driver-side can stay as it is below, > just add a second compatible). OK, I try to just use "rockchip,rk3228-gmac" to point to "rk322x_ops" which is the same structure in MAC driver, and both rk3228 and rk3229 use it. Thanks -- - Xing Zheng