Hi, On Fri, Jul 22, 2016 at 2:29 AM, Chanwoo Choi <cw00.choi at samsung.com> wrote: > Hi Chris, > > I'm sorry for late reply. I finished the first draft to support the extcon property. > You can check the patches[1]. But, I need more time to test it. After tested it, > I'll send the patches. > > [1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/log/?h=extcon-test > > Chanwoo Choi (4): > extcon: Add the extcon_type to group each connector into five category > extcon: Add the support for extcon property according to type of connector > extcon: Rename the extcon_set/get_state() to maintain the function naming pattern > extcon: Add the sync APIs to support the notification for extcon property > > Chris Zhong (1): > extcon: Add EXTCON_DISP_DP and the property for USB Type-C > Couple of comments: - In extcon.c, line 560: 'state' is unused. - extcon_set_property(edev, EXTCON_USB, EXTCON_USB_VBUS, 0); does not work. As written, it has to be something like: union extcon_property_value prop; ... prop.intval = vbus_state; extcon_set_property(edev, EXTCON_USB, EXTCON_USB_VBUS, prop); - For USB, the state of EXTCON_USB, EXTCON_USB_HOST, and EXTCON_DISP_DP tend to change at the same time, together with the associated properties. It might be desirable to have an equivalent of extcon_sync_all(edev); Thanks, Guenter
