Hi Paul, On 01/26/2016 08:45 AM, Paul Bolle wrote: > On ma, 2016-01-25 at 09:47 +0800, Yakir Yang wrote: >> --- a/drivers/gpu/drm/rockchip/Kconfig >> +++ b/drivers/gpu/drm/rockchip/Kconfig >> +config ROCKCHIP_INNO_HDMI >> + tristate "Rockchip specific extensions for Innosilicon HDMI" >> + depends on DRM_ROCKCHIP >> + help >> + This selects support for Rockchip SoC specific extensions >> + for the Innosilicon HDMI driver. If you want to enable >> + HDMI on RK3036 based SoC, you should selet this option. > (Really trivial: start indentation with tabs only, please. And > s/selet/select/.) Got it >> --- /dev/null >> +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c >> + * This software is licensed under the terms of the GNU General >> Public >> + * License version 2, as published by the Free Software Foundation, >> and >> + * may be copied, distributed, and modified under those terms. > This states this file is licensed GPL v2 only. > >> +MODULE_LICENSE("GPL"); > And, according to include/linux/module.h, this means "GNU Public License > v2 or later". > > So I think there's a (subtle) mismatch between the license ident used > for this driver and the comment above. Ah, thanks. - Yakir > Thanks, > > > Paul Bolle > > >