On 25-01-16 12:06, Julian Calaby wrote: > Hi Sjoerd, > > On Mon, Jan 25, 2016 at 9:47 PM, Sjoerd Simons > <sjoerd.simons at collabora.co.uk> wrote: >> On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it seems >> the card responds very quickly most of the time, unfortunately during >> initialisation it sometimes seems to take just a bit over 2 seconds to >> respond. >> >> This results intialization failing with message like: >> brcmf_c_preinit_dcmds: Retreiving cur_etheraddr failed, -52 >> brcmf_bus_start: failed: -52 >> brcmf_sdio_firmware_callback: dongle is not responding >> >> Increasing the timeout to allow for a bit more headroom allows the >> card to initialize reliably. >> >> A quick search online after diagnosing/fixing this showed that Google >> has a similar patch in their ChromeOS tree, so this doesn't seem >> specific to the board I'm using. >> >> Signed-off-by: Sjoerd Simons <sjoerd.simons at collabora.co.uk> > > Looks sane to me. > > Reviewed-by: Julian Calaby <julian.calaby at gmail.com> Not really a cleanup patch :-p , but thanks for the review. Regards, Arend > >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >> index dd66143..75ac4bd 100644 >> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >> @@ -45,8 +45,8 @@ >> #include "chip.h" >> #include "firmware.h" >> >> -#define DCMD_RESP_TIMEOUT msecs_to_jiffies(2000) >> -#define CTL_DONE_TIMEOUT msecs_to_jiffies(2000) >> +#define DCMD_RESP_TIMEOUT msecs_to_jiffies(2500) >> +#define CTL_DONE_TIMEOUT msecs_to_jiffies(2500) >> >> #ifdef DEBUG >> >> -- >> 2.7.0 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in >> the body of a message to majordomo at vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > >
