BTW, Caesar have you ever met this at RK3288 at booting time? [ 8.430582] thermal thermal_zone1: critical temperature reached(125 C),shutting down [ 8.439038] thermal thermal_zone2: critical temperature reached(125 C),shutting down [ 8.456344] thermal thermal_zone1: critical temperature reached(125 C),shutting down [ 8.465298] thermal thermal_zone2: critical temperature reached(125 C),shutting down On 12/12/2016 07:05 PM, Caesar Wang wrote: > There are five patches posted for upstream. > 89267b5 thermal: rockchip: improve conversion error messages > a0b5649 thermal: rockchip: don't pass table structs by value > bceed92 thermal: rockchip: fixes invalid temperature case > 30be6d0 thermal: rockchip: optimize the conversion table > 35636e9 thermal: rockchip: handle the set_trips without the trip points. > -- > > History version: > V1: > https://lkml.org/lkml/2016/11/22/250 > V2: > https://lkml.org/lkml/2016/11/23/348 > V3: > http://www.mail-archive.com/linux-kernel at vger.kernel.org/msg1281432.html > --- > > Brain posted the below patches for upstream. > 89267b5 thermal: rockchip: improve conversion error messages > a0b5649 thermal: rockchip: don't pass table structs by value > That make sense to improve efficiency > > Caesar post the below patches for upstream. > bceed92 thermal: rockchip: fixes invalid temperature case > 30be6d0 thermal: rockchip: optimize the conversion table > 35636e9 thermal: rockchip: handle the set_trips without the trip points. > That will fixes some issues in special cases. > -- > > Anyway, this series patches should can improve the rockchip thermal driver. > > > Changes in v4: > - As Eduardo and Brian commnets on > https://patchwork.kernel.org/patch/9449301 > - Print a better name. > - As Eduardo commented on https://patchwork.kernel.org/patch/9449313/ > - remove the Brain's review for previous version, since the new version > update something. > > Changes in v3: > - fix trivial thing for error message nd return value. > - change the commit. > - Fixes something as Brian comments on > > Changes in v2: > - As Brian commnets that restructure this to pass error codes back to the > upper layers. > - Improve the commit message. > - improve the commit as Brian commnets on https://patchwork.kernel.org/patch/9440985 > - Fixes something as Brian comments on > https://patchwork.kernel.org/patch/9440989. > > Changes in v1: > - The original Brian posted on https://patchwork.kernel.org/patch/9437686 > Note: it'd probably be even nicer to know which sensor this was, but we've > kinda abstracted that one away by this point... > - The original Brian posted on https://patchwork.kernel.org/patch/9437687 > > Brian Norris (2): > thermal: rockchip: improve conversion error messages > thermal: rockchip: don't pass table structs by value > > Caesar Wang (3): > thermal: rockchip: fixes invalid temperature case > thermal: rockchip: optimize the conversion table > thermal: rockchip: handle set_trips without the trip points > > drivers/thermal/rockchip_thermal.c | 153 ++++++++++++++++++++++++------------- > 1 file changed, 100 insertions(+), 53 deletions(-) >
