? 2016?11?30? 13:04, Eduardo Valentin ??: > Hey, > > On Mon, Nov 28, 2016 at 09:47:29PM -0800, Brian Norris wrote: >> Hi, >> > <cut> > >>>> + __func__, table.mode); >>> Given that we are improving messages, would it be more informative to >>> say that you have an invalid table mode? >> I considered the mode and ID listing to go hand in hand, so it was the >> whole table that is wrong. But it is just as well to say the "table >> mode" is wrong. >> >> Maybe even better: "%s: unknown table mode: %d\n". >> > Yup, that works for me, even better. Done. Sorry for delay. >> And I guess same answer for patch 4, where you had the same question. > yes > >> Brian >> >>>> + return -EINVAL; > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
