On Fri, 2016-08-19 at 22:41 +0200, Heiko Stuebner wrote: > > > So no, don't *add* any more of these functions. Only add the generic > > version. And if your driver isn't using the generic property > > functions... fix it. > > As far as I can see, all the device_property_* functions are grounded on their > of_property_*, acpi_property_* etc counterparts and functions reading specific > elements (the _index variants) are currently not available at all. > > drivers/base/property.c: > #define OF_DEV_PROP_READ_ARRAY(node, propname, type, val, nval)?????????????????????????\ > ????????(val) ? of_property_read_##type##_array((node), (propname), (val), (nval))??????\ > ????????????? : of_property_count_elems_of_size((node), (propname), sizeof(type)) > > So even if you're using the device_property_* functions you'd still need > a match in the underlying functions or am I missing something? Yes, but the underlying function should never be used directly by drivers. And should probably be prefixed with __ or marked deprecated (with an override in its one genuine call site). -- dwmw2 -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 5760 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-rockchip/attachments/20160819/9c638728/attachment.bin>
