On Mon, Apr 18, 2016 at 11:35:59AM +0800, Caesar Wang wrote: > From: Mikko Perttunen <mperttunen at nvidia.com> > > This adds support for hardware-tracked trip points to the device tree <cut> > diff --git a/include/linux/thermal.h b/include/linux/thermal.h > index 97b86c5..6ef932a 100644 > --- a/include/linux/thermal.h > +++ b/include/linux/thermal.h > @@ -335,12 +335,14 @@ struct thermal_genl_event { > * @get_trend: a pointer to a function that reads the sensor temperature trend. > * @set_emul_temp: a pointer to a function that sets sensor emulated > * temperature. > + * @set_trips: a pointer to a function that set low/high trip temperature. > */ > struct thermal_zone_of_device_ops { > int (*get_temp)(void *, int *); > int (*get_trend)(void *, long *); > int (*set_emul_temp)(void *, int); > int (*set_trip_temp)(void *, int, int); > + int (*set_trips)(void *, int, int); This is unfortunately a diverges from API available on thermal core. Can you please add first on thermal core then, use it in of thermal? I don't want to have callbacks available only via of thermal. If we allow it, OF thermal becomes a separate API. > }; > > /** > -- > 1.9.1 >