On 09/17/2015 11:28 AM, Caesar Wang wrote: > Hi Daniel, > > > ? 2015?09?17? 17:11, Daniel Lezcano ??: >> >> Hi Caesar, >> >> >> On 09/17/2015 09:51 AM, Caesar Wang wrote: >>> Build the arm64 SoCs (e.g.: RK3368) on Rockchip platform, >>> There are some failure with build up on timer driver for rockchip. >>> >>> logs: >>> ... >>> drivers/clocksource/rockchip_timer.c:156:13: error: 'NO_IRQ' undeclared >> >> I think the NO_IRQ definition is missing for ARM64. > > Yep, Maybe better to compatible if we don't use the 'NO_IRQ', Hmm, after digging into drivers/of/irq.c and kernel/irq/irqdomain.c when there is an error it returns zero. So NO_IRQ and -1 are not correct and on the other side zero can be a valid irq. That sounds a little bit fuzzy to me. >>> /tmp/ccdAnNy5.s:47: Error: missing immediate expression at operand 1 -- >>> `dsb` >>> ... >>> >>> The problem was different semantics of dsb on btw arm32 and arm64, >>> Here we can convert the dsb with insteading of dsb(sy). >> >> What happens to ARM32 then ? >> > > The dsb() is ok for ARM32, the ARM32/64 are OK if we can convert the > dsb() to dsb(sy). > I believe all drivers with 'dsb()' have same issue on ARM64 platform. > >>> Meanwhile, I change a bit to make the code more readability for driver >>> when I check the code style. >>> >>> Signed-off-by: Caesar Wang <wxt at rock-chips.com> >> >> > > -- <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
