On Wed, Oct 28, 2015 at 3:28 AM, Yakir Yang <ykk at rock-chips.com> wrote: > Rockchip DP driver is a helper driver of analogix_dp coder driver, > so most of the DT property should be descriped in analogix_dp document. > > Reviewed-by: Heiko Stuebner <heiko at sntech.de> > Signed-off-by: Yakir Yang <ykk at rock-chips.com> > --- Looks mostly fine to me. [...] > +- rockchip,grf: this soc should set GRF regs, so need get grf here. > + > +- ports: contain a port node with endpoint definitions as defined in > + Documentation/devicetree/bindings/media/video-interfaces.txt. Please document that you have 2 ports 0 and 1, port0 has 2 endpoints for ? and port1 has 1 endpoint connected to a panel(or another bridge). Otherwise that is only evident from the example. Rob
