Hi Heiko, On 10/29/2015 04:36 AM, Heiko Stuebner wrote: > Hi Yakir, > > Am Mittwoch, 28. Oktober 2015, 16:30:33 schrieb Yakir Yang: >> +static int rockchip_dp_phy_probe(struct platform_device *pdev) >> +{ >> + struct device *dev = &pdev->dev; >> + struct device_node *np = dev->of_node; >> + struct phy_provider *phy_provider; >> + struct rockchip_dp_phy *dp; >> + struct resource *res; > drivers/phy/phy-rockchip-dp.c: In function 'rockchip_dp_phy_probe': > drivers/phy/phy-rockchip-dp.c:86:19: warning: unused variable 'res' [-Wunused-variable] Oh, thanks, would send v9 of this one alone. - Yakir >> + struct phy *phy; >> + int ret; >> + >> + if (!np) >> + return -ENODEV; >> + >> + dp = devm_kzalloc(dev, sizeof(*dp), GFP_KERNEL); >> + if (IS_ERR(dp)) >> + return -ENOMEM; >> + >> + dp->dev = dev; >> + >> + dp->phy_24m = devm_clk_get(dev, "24m"); >> + if (IS_ERR(dp->phy_24m)) { >> + dev_err(dev, "cannot get clock 24m\n"); >> + return PTR_ERR(dp->phy_24m); >> + } >> + >> + ret = clk_set_rate(dp->phy_24m, 24000000); >> + if (ret < 0) { >> + dev_err(dp->dev, "cannot set clock phy_24m %d\n", ret); >> + return ret; >> + } >> + > > >