Hi Rob, ? 2015?10?21? 23:18, Rob Herring ??: > On Tue, Oct 20, 2015 at 9:42 PM, Caesar Wang <wxt at rock-chips.com> wrote: >> Add the OTP gpio state, we need switch the pin to gpio state >> before the TSADC controller is reset. >> >> Signed-off-by: Caesar Wang <wxt at rock-chips.com> >> --- >> >> Changes in v1: >> - As the Doug comments, add the 'init' property to sync document. >> >> Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt >> index ef802de..28e84f7 100644 >> --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt >> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt >> @@ -27,8 +27,9 @@ tsadc: tsadc at ff280000 { >> clock-names = "tsadc", "apb_pclk"; >> resets = <&cru SRST_TSADC>; >> reset-names = "tsadc-apb"; >> - pinctrl-names = "default"; >> - pinctrl-0 = <&otp_out>; >> + pinctrl-names = "init", "default"; >> + pinctrl-0 = <&otp_gpio>; >> + pinctrl-1 = <&otp_out>; > Are these optional or required? They only appear in the example. Yep, These are required for TSADC. I?m assumed that's right, I think we don't need to introduce the pinctrl in this document. > Rob > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip