Heiko, On Thu, Nov 19, 2015 at 1:22 PM, Heiko Stuebner <heiko at sntech.de> wrote: > We need custom handling for these two socs in the driver shortly, > so add the necessary compatible values to binding and driver. > > Signed-off-by: Heiko Stuebner <heiko at sntech.de> > --- > Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt | 5 ++++- > drivers/phy/phy-rockchip-usb.c | 2 ++ > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt > index 826454a..9b37242 100644 > --- a/Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt > +++ b/Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt > @@ -1,7 +1,10 @@ > ROCKCHIP USB2 PHY > > Required properties: > - - compatible: rockchip,rk3288-usb-phy > + - compatible: matching the soc type, one of > + "rockchip,rk3066a-usb-phy" > + "rockchip,rk3188-usb-phy" > + "rockchip,rk3288-usb-phy" I can never quite keep it straight how this is supposed to work, but since previously only "rockchip,rk3288-usb-phy" was supported and now we have these new compatible strings, I would have expected the new strings to specify the old ones as fallback. That would mean your choices would be: - "rockchip,rk3288-usb-phy" - A real rk3288 - "rockchip,rk3188-usb-phy", "rockchip,rk3288-usb-phy" - A rk3188 with fallback to 3288 driver. - "rockchip,rk3066a-usb-phy", "rockchip,rk3288-usb-phy" - A rk3066a with fallback to 3288 driver. That means that if you land the dts changes without the driver changes that things still work OK. -Doug
