Hi Alex, On Fri, Mar 27, 2015 at 10:24:22PM -0600, Alex Williamson wrote: > For 1-5,16 > > Reviewed-by: Alex Williamson <alex.williamson at redhat.com> Thanks a lot for your review. > My only comment/question is whether you'd want to consider using > ERR_PTR() return values from domain_alloc(). It's an alloc functions, > so NULL == -ENOMEM is pretty standard, but we could at least have the > interface to the iommu driver return more info even if we continue to > mask that as NULL out to the IOMMU API users for now. Thanks, Yes, that might make sense. But to do anything useful with the ERR_PTR we also need to change the iommu_domain_alloc() interface. This is out-of-scope for this patch-set, we can discuss this seperatly. Joerg
