? 2015/3/2 17:07, Paul Bolle ??: > On Sat, 2015-02-28 at 22:04 -0500, Yakir Yang wrote: >> --- /dev/null >> +++ b/sound/soc/rockchip/rockchip_hdmi_audio.c >> @@ -0,0 +1,169 @@ >> +/* >> + * rockchip-hdmi-card.c > Doesn't match the filename. Is this line needed anyway? Thanks, this comment are good for read, and seems others codec driver also content this comment, so I think we can keep this comment. I will correct the file name it in next version. Thanks for you reply :) >> + * >> + * ROCKCHIP ALSA SoC DAI driver for HDMI audio on rockchip processors. >> + * Copyright (c) 2014, ROCKCHIP CORPORATION. All rights reserved. >> + * Authors: Yakir Yang <ykk at rock-chips.com> >> + * >> + * This program is free software; you can redistribute it and/or modify it >> + * under the terms and conditions of the GNU General Public License, >> + * version 2, as published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope it will be useful, but WITHOUT >> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for >> + * more details. >> + * >> + * You should have received a copy of the GNU General Public License >> + * along with this program. If not, see <http://www.gnu.org/licenses/>.* >> + * >> + */ > This states the license is plain GPL v2. Okay, thanks, correct it in next version. Thanks Yakir Yang Best regards. >> +MODULE_LICENSE("GPL"); > So you probably want > MODULE_LICENSE("GPL v2"); > > here. > > > Paul Bolle > > > >
