On 6/8/2015 9:01 PM, Masahiro Yamada wrote: > Currently, pinctrl_register() just returns NULL on error, so the > callers can not know the exact reason of the failure. > > Some of the pinctrl drivers return -EINVAL, some -ENODEV, and some > -ENOMEM on error of pinctrl_register(), although the error code > might be different from the real cause of the error. > > This commit reworks pinctrl_register() to return the appropriate > error code and modifies all of the pinctrl drivers to use IS_ERR() > for the error checking and PTR_ERR() for getting the error code. > > Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com> > --- > > This patch is based on linux-pinctrl/devel > (Commit 7164873e7c69d6bab74726debc3b495a86332b1f). > > I think I converted all of the pinctrl drivers, but just in case, > I'd like the driver maintainers to check this patch out. > > > drivers/pinctrl/bcm/pinctrl-bcm281xx.c | 4 ++-- > drivers/pinctrl/bcm/pinctrl-cygnus-gpio.c | 4 ++-- > drivers/pinctrl/bcm/pinctrl-cygnus-mux.c | 4 ++-- Acked-by: Ray Jui <rjui at broadcom.com>