Hi Boris, Quoting Boris Brezillon (2015-11-16 00:56:26) > diff --git a/drivers/clk/clk-pwm.c b/drivers/clk/clk-pwm.c > index 328fcfc..b6306a2 100644 > --- a/drivers/clk/clk-pwm.c > +++ b/drivers/clk/clk-pwm.c > @@ -71,22 +71,23 @@ static int clk_pwm_probe(struct platform_device *pdev) > if (IS_ERR(pwm)) > return PTR_ERR(pwm); > > - if (!pwm->period) { > + if (!pwm_get_period((pwm))) { The change itself looks fine, but the semantic patch added extra parens. Can you remove them? After doing so feel free to add: Acked-by: Michael Turquette <mturquette at baylibre.com>