[PATCH] ARM: dts: rockchip: Adding LEDs handling via leds-gpio for the Radxa Rock2 Square

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2015-12-30 at 16:53 +0100, Heiko St?bner wrote:
> Am Mittwoch, 30. Dezember 2015, 16:45:43 schrieb Sjoerd Simons:
> > On Wed, 2015-12-30 at 16:20 +0100, Heiko St?bner wrote:
> > >?
> I only looked at the schematics, so missed that. While personally I'd
> still?
> like having the "christmas-tree" off by default, Sjoerd's argument
> for the?
> trigger-choice sounds sensible.
> Hint for next time: Describing that makes a good commit message
> 
> Anybody opposed to me adding the following commit message?
> 
> ----
> Describe the two user-controllable LEDs on Rock2-square boards.
> The default-triggers mimic the behaviour of the vendor-kernel to
> keep functionalities in sync.
> ----

Looks good to me, with that commit message feel free to add:

Reviewed-by: Sjoerd Simons <sjoerd.simons at collabora.co.uk>
> 
> Heiko
> 

-- 
Sjoerd Simons
Collabora Ltd.



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux