On Tue, Dec 08, 2015 at 02:03:23PM +0100, Wolfram Sang wrote: > > > Too many && use_defaults. What about > > > > memset(t, 0, sizeof(*t)); > > > > device_property_read_u32(dev, "i2c-scl-internal-delay-ns", &t- > > >scl_int_delay_ns); > > > > if (!use_defaults) > > ?return; > > I like this! Thanks for the input. Oops, too enthusiastic. This skips parsing all the other properties... The defaults should only be applied if reading the properties fails. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-rockchip/attachments/20151208/8957c613/attachment.sig>
