Chris, On Tue, Sep 23, 2014 at 8:53 AM, Chris Zhong <zyw at rock-chips.com> wrote: > Get voltage & duty table from device tree might be better, other platforms can also use this > driver without any modify. > > Signed-off-by: Chris Zhong <zyw at rock-chips.com> > Reviewed-by: Doug Anderson <dianders at chromium.org> I finally managed to get everything setup and I've now tested this myself on an rk3288-based board. Tested-by: Doug Anderson <dianders at chromium.org> I'd imagine the next step is for Lee to comment on the patch and when he's happy with it Mark Brown will land it? One thing that's still a bit odd (though no different than the behavior of the driver from before you touched it, so it shouldn't block landing IMHO) is that at boot time this regulator will report that it's at the highest voltage but the voltage won't actually change until the first client sets the voltage. Also: if anyone reading is interested in this patch, it's possible you'll also be interested in my patch at <https://patchwork.kernel.org/patch/4960731/> to make sue that your voltage doesn't twiddle around at probe time. -Doug
