Hello.
On 09/14/2014 06:29 AM, Jianqun wrote:
>>> Reference rockchip I2S controller TRM, modify some registers' property
>>> I2S_FIFOLR: read / write, but not volatile, not precious
>>> I2S_INTSR: read / write
>>> I2S_CLR: volatile, register value will be cleared by read
>>> Test on RK3288 with max98090.
>>> Signed-off-by: Jianqun Xu <jay.xu at rock-chips.com>
>>> ---
>>> sound/soc/rockchip/rockchip_i2s.c | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>> diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c
>>> index 1b9b404..6595383 100644
>>> --- a/sound/soc/rockchip/rockchip_i2s.c
>>> +++ b/sound/soc/rockchip/rockchip_i2s.c
>> [...]
>>> @@ -385,8 +387,6 @@ static bool rockchip_i2s_volatile_reg(struct device *dev, unsigned int reg)
>>> static bool rockchip_i2s_precious_reg(struct device *dev, unsigned int reg)
>>> {
>>> switch (reg) {
>>> - case I2S_FIFOLR:
>>> - return true;
>>> default:
>>> return false;
>>> }
>> Shouldn't this be folded into simple *return* false now?
> That is more reasonable, thank you.
Moreover, this function may be completely eliminated.
WBR, Sergei
