On Sat, Sep 13, 2014 at 08:43:13AM +0800, Jianqun wrote: > +++ b/sound/soc/rockchip/rockchip_i2s.c > @@ -423,6 +423,11 @@ static int rockchip_i2s_probe(struct platform_device *pdev) > dev_err(&pdev->dev, "Can't retrieve i2s bus clock\n"); > return PTR_ERR(i2s->hclk); > } > + ret = clk_prepare_enable(i2s->hclk); > + if (ret) { > + dev_err(i2s->dev, "hclock enable failed %d\n", ret); > + return ret; > + } BTW: you're also missing a clk_disable_unprepare() in the remove path here, please send a followup fixing that. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-rockchip/attachments/20140913/2476a185/attachment-0001.sig>