It is an optional property used by arc-emac (the core driver), if it is not present the core driver generates one for you. Problem being that with this property two radxa rock boards connected on the same local network might have the same mac address. In this case it would be probably better to remove this property. What do you think ? 2014-09-03 17:29 GMT+02:00 Naoki FUKAUMI <naobsd at gmail.com>: > On Wed, Sep 3, 2014 at 7:27 PM, Romain Perier <romain.perier at gmail.com> wrote: >> This enables EMAC Rockchip support on radxa rock boards. >> >> Signed-off-by: Romain Perier <romain.perier at gmail.com> >> --- >> arch/arm/boot/dts/rk3188-radxarock.dts | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts b/arch/arm/boot/dts/rk3188-radxarock.dts >> index 5e4e3c23..e1358d3 100644 >> --- a/arch/arm/boot/dts/rk3188-radxarock.dts >> +++ b/arch/arm/boot/dts/rk3188-radxarock.dts >> @@ -76,6 +76,24 @@ >> }; >> }; >> >> +&emac { >> + status = "okay"; >> + compatible = "rockchip,rk3188-emac"; >> + >> + pinctrl-names = "default"; >> + pinctrl-0 = <&emac_xfer>, <&emac_mdio>, <&phy_int>; >> + >> + mac-address = [ c6 ef 91 8e 60 4b ]; > > is "mac-address" required?