On 2014?11?14? 18:53, Zubair Lutfullah Kakakhel wrote:
>
> On 14/11/14 10:37, Andy Yan wrote:
>> On 2014?11?14? 18:23, Zubair Lutfullah Kakakhel wrote:
>>> Hi Andy
>>>
>>> On 14/11/14 03:31, Andy Yan wrote:
>>>> Rockchip RK3288 hdmi is compatible with dw_hdmi
>>>>
>>>> Signed-off-by: Andy Yan <andy.yan at rock-chips.com>
>>>>
>>>> ---
>>>>
>>>> Changes in v10:
>>>> - add more display mode support mpll configuration for rk3288
>>>>
>>>> Changes in v9:
>>>> - move some phy configuration to platform driver
>>>>
>>>> Changes in v8: None
>>>> Changes in v7: None
>>>> Changes in v6: None
>>>> Changes in v5: None
>>>> Changes in v4: None
>>>> Changes in v3: None
>>>> Changes in v2: None
>>>>
>>>> drivers/gpu/drm/bridge/dw_hdmi.c | 10 +
>>>> drivers/gpu/drm/bridge/dw_hdmi.h | 3 +-
>>>> drivers/gpu/drm/rockchip/Kconfig | 10 +
>>>> drivers/gpu/drm/rockchip/Makefile | 2 +-
>>>> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 355 ++++++++++++++++++++++++++++
>>>> include/drm/bridge/dw_hdmi.h | 1 +
>>>> 6 files changed, 379 insertions(+), 2 deletions(-)
>>>> create mode 100644 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
>>>>
>>>> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
>>>> index a2876fe..1dd1f0b 100644
>>>> --- a/drivers/gpu/drm/bridge/dw_hdmi.c
>>>> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c
>>>> @@ -715,6 +715,13 @@ static void dw_hdmi_phy_enable_tmds(struct dw_hdmi *hdmi, u8 enable)
>>>> HDMI_PHY_CONF0_ENTMDS_MASK);
>>>> }
>>>> +static void dw_hdmi_phy_enable_spare(struct dw_hdmi *hdmi, u8 enable)
>>>> +{
>>>> + hdmi_mask_writeb(hdmi, enable, HDMI_PHY_CONF0,
>>>> + HDMI_PHY_CONF0_SPARECTRL_OFFSET,
>>>> + HDMI_PHY_CONF0_SPARECTRL_MASK);
>>>> +}
>>>> +
>>> What does enable spare do? Can other future SoCs use it?
>>>
>>> This looks like DW specific. And can be a separate commit that adds a feature to the dw hdmi driver.
>> Actually I am not very clearly about this bit, but RK3288 HDMI will not work without this bit enable.
>> On imx6, the description about this bit is:Reserved. Spare pin control.
>> On rk3288, the description is: svsret/sparectrl
>> Both are very simple.
> Sounds like the IP Core in the rk3288 is slightly upgraded.
> Separate this section in a different commit as it is generic DW stuff.
>
> And add what you wrote above in the commit message.
Only Separate function dw_hdmi_phy_enale_spare ? not include
if (hdmi->dev_type == rk3288_hdmi)
dw_hdmi_enable_phy_spare(hdmi, 1);
?
>
> Thanks
> ZubairLK
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
