On 2014?11?14? 18:55, Zubair Lutfullah Kakakhel wrote: > > On 14/11/14 10:53, Andy Yan wrote: >> Hi ZubairLK: >> Thanks for your review. >> On 2014?11?14? 18:19, Zubair Lutfullah Kakakhel wrote: >>> Hi Andy, >>> >>> Nice work on this patch series. Its getting better and better :). >>> >>> On 14/11/14 03:27, Andy Yan wrote: >>>> hdmi phy clock symbol and transmission termination value >>>> can adjust platform specific to get the best SI >>> ^Is this signal integrity? >> yes , SI is signal integrity, such as eye diagram measurement >>> Are these two disjoint features in separate patches? >>> >>>> also add mode_valid interface for some platform may not support >>>> all the display mode >>> Sounds like another separate patch to me. :) >> they can seperate >>> Also, This series is becoming quite large. With major changes and fixes mixed together. >>> >>> Patch 3 splits imx-drm. >>> Patch 4 moves dw-drm out of imx-drm folder. >>> Patch 7 adds binding >>> Patch 9 converts to drm bridge. >>> >>> Can these be placed together easily? >>> And in the start. i.e. patch 1, 2, 3, 4, >>> >>> Then all fixes etc can come afterwards? >>> >>> It helps when checking histories later as to how a driver was made and how fixes happened. >>> >>> Especially when file moves happen.. >> Do you mean we can rearrange the patch series? >> put patch 3, 4 ,7, 9 together one bye one >> than followed by the fixes patches 5 ,6, 8, 11 ? > Yes. Rearrange so that the split imx-drm/imx-hdmi and conversion to drm-bridge is at the start of the series. > Then the rest are bug fixes and feature additions. Can I put patch#1(make checkpatch happy) and patch#2 (defer probe) as the first two patch. Daniel from Google chromium think it's better to put the two slightly changes in the front for easy review. > Cheers, > ZubairLK > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
