Alex, On Thu, Dec 18, 2014 at 3:01 PM, Alexandru M Stan <amstan at chromium.org> wrote: > + blk_test = kmalloc(blksz, GFP_KERNEL); > + if (!blk_test) > + return -ENOMEM; > + > + ranges = kmalloc(((NUM_PHASES / 2 + 1) * sizeof(ranges)), GFP_KERNEL); sizeof(*ranges) Other than that, this looks good to me and you can add my reviewed-by when the above is fixed.