Hi, On Thu, Dec 11, 2014 at 10:46 AM, Doug Anderson <dianders at chromium.org> wrote: > Yunzhi, > > On Thu, Dec 11, 2014 at 1:55 AM, Yunzhi Li <lyz at rock-chips.com> wrote: >> This patch adds a binding that describes the Rockchip usb PHYs >> found on Rockchip SoCs usb interface. > > Technically the bindings patch is supposed to come before the driver. > So this should be patch #1 and the driver patch #2. > > >> +Required properties: >> + - compatible: rockchip,rk3288-usb-phy >> + - rockchip,grf : phandle to the syscon managing the "general >> + register files" >> + - #phy-cells: should be 1 >> + - #address-cells: should be 1 >> + - #size-cells: should be 0 >> + >> +Sub-nodes: >> +Each PHY should be represented as a sub-node. >> + >> +Sub-nodes >> +required properties: >> +- reg: the PHY number >> + "0" - PHY connect to OTG controller >> + "1" - PHY connect to HOST0 controller >> + "2" - PHY connect to HOST1 controller > > You don't have any sub nodes and are using the phy-cells. Seems like > you should get rid of this? ...or I guess switch to using sub nodes > and set "phy-cells" to 0? Oh. You actually have them in the ".dtsi" patch, but not here in the example. Hrm. I don't know enough about phys in general to say whether they're needed (I will learn if someone else on this thread doesn't just know), but if they are required then they ought to be in the example...
