Hi Tomasz, On Wed, Jul 04, 2018 at 06:04:35PM +0900, Tomasz Figa wrote: > On Wed, Jul 4, 2018 at 5:55 PM Baruch Siach <baruch at tkos.co.il> wrote: > > So to get the rockchip-vpu driver working with current kernel I need to > > also forward-port the embryonic Request API as well. I'll look into this. > > > > Are you aware of any other dependencies? > > I think V4L2 compound controls, but that should be already in > upstream. I'll try to look up relevant Chromium kernel patches for you > a bit later. > > > The alternative for me is to back-port rkisp1 video capture driver to vendor > > provided 4.4 kernel so I can use the MPP shim driver. I hope to not get there. > > > > The easiest option, of course, is to just wait for the Request API and the new > > codec driver. I'm not sure I can afford to wait though. > > I think you could also try to remove the use of config stores and make > the driver latch control values in QBUF(OUTPUT). You would also need > to adjust the plugin code accordingly. I'm trying to wrap me head around the config_store implementation in the 'chromeos-4.4' kernel branch (commit a36974eae81a). I think I get the general idea. Still need to figure out the details. I'm not sure I get your QBUF(OUTPUT) suggestion, though. Does "latch" means that the driver attaches the same controls to all buffers, essentially behaving like a traditional V4L2 device? Something else? The limitation of being able to encode only one stream at a time is acceptable for my application. Thanks, baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -