Re: [PATCH] dt-bindings: serial: snps-dw-apb-uart: document RZ/N1 binding without DMA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

On Tue, 18 Mar 2025 at 09:54, Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> Renesas RZ/N1D has this UART with and without DMA support. Currently,
> only the binding with DMA support is described. Add the missing one
> without DMA support which can fallback even more.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> @@ -13,6 +13,20 @@ allOf:
>    - $ref: serial.yaml#
>    - $ref: rs485.yaml#
>
> +  - if:
> +      properties:
> +        compatible:
> +          items:
> +            - enum:
> +                - renesas,r9a06g032-uart
> +                - renesas,r9a06g033-uart

I think you can simplify by replacing the enum by

    - pattern: "^renesas,.*$"

> +            - const: renesas,rzn1-uart
> +            - const: snps,dw-apb-uart
> +    then:
> +      properties:
> +        dmas: false
> +        dma-names: false
> +
>    - if:
>        properties:
>          compatible:

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux