Hi Geert,
Thanks for the feedback.
> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 14 March 2025 16:07
> Subject: Re: [PATCH 10/11] arm64: dts: renesas: r9a09g047: Add CANFD node
>
> Hi Biju,
>
> On Tue, 18 Feb 2025 at 11:50, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > Add CANFD node to RZ/G3E ("R9A09G047") SoC DTSI.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> > @@ -272,6 +272,68 @@ scif0: serial@11c01400 {
> > status = "disabled";
> > };
> >
> > + canfd: can@12440000 {
> > + compatible = "renesas,r9a09g047-canfd";
> > + reg = <0 0x12440000 0 0x40000>;
> > + interrupts = <GIC_SPI 709 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 710 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 697 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 703 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 711 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 698 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 704 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 712 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 699 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 705 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 713 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 700 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 706 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 714 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 701 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 707 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 715 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 702 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 708 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 716 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-names = "g_err", "g_recc",
> > + "ch0_err", "ch0_rec", "ch0_trx",
> > + "ch1_err", "ch1_rec", "ch1_trx",
> > + "ch2_err", "ch2_rec", "ch2_trx",
> > + "ch3_err", "ch3_rec", "ch3_trx",
> > + "ch4_err", "ch4_rec", "ch4_trx",
> > + "ch5_err", "ch5_rec", "ch5_trx";
> > + clocks = <&cpg CPG_MOD 156>,
> > + <&cpg CPG_MOD 157>,
> > + <&cpg CPG_MOD 158>;
>
> Please use hexadecimal module clock numbers...
OK.
>
> > + clock-names = "fck", "ram_clk", "can_clk";
> > + assigned-clocks = <&cpg CPG_MOD 158>;
> > + assigned-clock-rates = <80000000>;
> > + resets = <&cpg 161>,
> > + <&cpg 162>;
>
> ... and resets, like is used for all other modules.
Agreed, will use hexa decimal numbers.
Cheers,
Biju
