Hi Fabrizio, On Do, 2025-03-13 at 10:14 +0000, Fabrizio Castro wrote: > Hi Philipp, > > Thanks for your feedback! > > > From: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > > Sent: 13 March 2025 08:37 > > Subject: Re: [PATCH v2 2/2] reset: Add USB2PHY control driver for Renesas RZ/V2H(P) > > > > On Mi, 2025-03-05 at 12:39 +0000, Prabhakar wrote: > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > > > Add support for the USB2PHY control driver on the Renesas RZ/V2H(P) SoC. > > > Make the driver handle reset and power-down operations for the USB2PHY. > > > > > > Pass OF data to support future SoCs with similar USB2PHY hardware but > > > different register configurations. Define device-specific initialization > > > values and control register settings in OF data to ensure flexibility > > > for upcoming SoCs. > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > --- > > > drivers/reset/Kconfig | 7 + > > > drivers/reset/Makefile | 1 + > > > drivers/reset/reset-rzv2h-usb2phy-ctrl.c | 223 +++++++++++++++++++++++ > > > 3 files changed, 231 insertions(+) > > > create mode 100644 drivers/reset/reset-rzv2h-usb2phy-ctrl.c > > > [...] > > > diff --git a/drivers/reset/reset-rzv2h-usb2phy-ctrl.c b/drivers/reset/reset-rzv2h-usb2phy-ctrl.c > > > new file mode 100644 > > > index 000000000000..a6daeaf37e1c > > > --- /dev/null > > > +++ b/drivers/reset/reset-rzv2h-usb2phy-ctrl.c > > > @@ -0,0 +1,223 @@ [...] > > > +static const struct rzv2h_usb2phy_regval rzv2h_init_vals[] = { > > > + { .reg = 0xc10, .val = 0x67c }, > > > + { .reg = 0xc14, .val = 0x1f }, > > > + { .reg = 0x600, .val = 0x909 }, > > > > What are these registers and what are those values doing? > > Unfortunately, there are some licensing restrictions on this IP, this is > the best that we can do, as per the license agreement. How am I expected to review this? For now, I'll assume that these registers are not related to reset functionality at all, and that this driver should be a phy controller driver instead of a reset controller driver. Can you convince me otherwise without breaking license agreements? regards Philipp