Hi Geert, > -----Original Message----- > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Sent: 07 March 2025 08:37 > Subject: Re: [PATCH v2 2/8] memory: renesas-rpc-if: Move rpc-if reg definitions > > Hi Biju, > > On Thu, 6 Mar 2025 at 18:09, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > Move rpc-if reg definitions to a header file for the preparation of > > adding support for RZ/G3E XSPI that has different register definitions. > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > Thanks for your patch! > > > --- /dev/null > > +++ b/drivers/memory/renesas-rpc-if-regs.h > > > +#define RPCIF_DRENR_CDB(o) (u32)((((o) & 0x3) << 30)) > > scripts/checkpatch.pl says: > ERROR: Macros with complex values should be enclosed in parentheses > > And indeed, you misplaced the cast, outside the (double) parentheses. Agreed. Will fix this before moving it to here as a separate patch. Cheers, Biju
