Hi Geert, On Thu, Mar 6, 2025 at 2:43 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > On Fri, 28 Feb 2025 at 21:27, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Unlike dynamic dividers, static dividers do not have a monitor bit. > > Introduce the `DEF_CSDIV()` macro for defining static dividers, ensuring > > consistency with existing dynamic divider macros. > > > > Additionally, introduce the `CSDIV_NO_MON` macro to indicate the absence > > of a monitor bit, allowing the monitoring step to be skipped when > > `mon` is set to `CSDIV_NO_MON`. > > > > Note, `rzv2h_cpg_ddiv_clk_register()` will be re-used instead of generic > > `clk_hw_register_divider_table()` for registering satic dividers > > as some of the static dividers require RMW operations. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Thanks for your patch! > > I understand this is in preparation of adding GBETH/XSPI clocks, and > thus related to "[PATCH 2/4] clk: renesas: rzv2h-cpg: Add support for > static dividers"[1]? > I will send out patches for GBETH clocks which will use the DEF_CSDIV() macro. Basically DEF_CSDIV() macro will be used IPs which require RMW operations whereas in case Biju's patch DEF_SDIV() macro will be used IP's which do not need RMW operations. Cheers, Prabhakar