Hi Marc,
Thanks for the feedback.
> -----Original Message-----
> From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> Sent: 25 February 2025 15:48
> Subject: Re: [PATCH v3 06/11] can: rcar_canfd: Add register mapping table to struct rcar_canfd_hw_info
>
> On 25.02.2025 15:40:45, Biju Das wrote:
> > R-Car Gen3 and Gen4 has some differences in the register offsets. Add
> > a mapping table to handle these differences.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v3:
> > * New patch.
> > ---
> > drivers/net/can/rcar/rcar_canfd.c | 48
> > ++++++++++++++++++++++++++-----
> > 1 file changed, 41 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/net/can/rcar/rcar_canfd.c
> > b/drivers/net/can/rcar/rcar_canfd.c
> > index f71725da57ce..268b9b8835c4 100644
> > --- a/drivers/net/can/rcar/rcar_canfd.c
> > +++ b/drivers/net/can/rcar/rcar_canfd.c
>
> [...]
>
> > +enum rcar_canfd_reg_offset_id {
> > + RFCC, /* RX FIFO Configuration/Control Register */
> > + CFCC, /* Common FIFO Configuration/Control Register */
> > + CFSTS, /* Common FIFO Status Register */
> > + CFPCTR, /* Common FIFO Pointer Control Register */
> > + F_DCFG, /* Global FD Configuration Register */
> > + RFOFFSET, /* Receive FIFO buffer access ID register */
> > + CFOFFSET, /* Transmit/receive FIFO buffer access ID register */
> > +};
>
> Please add a common prefix to the enums, i.e. RCANFD
OK, will fix this in next version.
Cheers,
Biju
