Hi Marc,
> -----Original Message-----
> From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> Sent: 25 February 2025 15:50
> Subject: Re: [PATCH v3 07/11] can: rcar_canfd: Add mask table to struct rcar_canfd_hw_info
>
> On 25.02.2025 15:40:46, Biju Das wrote:
> > R-Car Gen3 and Gen4 has some differences in the mask bits. Add a mask
> > table to handle these differences.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v3:
> > * New patch.
> > ---
> > drivers/net/can/rcar/rcar_canfd.c | 68
> > +++++++++++++++++++++++++------
> > 1 file changed, 55 insertions(+), 13 deletions(-)
> >
> > diff --git a/drivers/net/can/rcar/rcar_canfd.c
> > b/drivers/net/can/rcar/rcar_canfd.c
> > index 268b9b8835c4..fcf5cb93f57c 100644
> > --- a/drivers/net/can/rcar/rcar_canfd.c
> > +++ b/drivers/net/can/rcar/rcar_canfd.c
>
> > +enum rcar_canfd_mask_id {
> > + EEF_MASK_ID, /* Global Error Flag */
> > + RNC_MASK_ID, /* Rule Number for Channel */
> > + AFLPN_MASK_ID, /* Acceptance Filter List Page Number */
> > + NTSEG2_MASK_ID, /* Nominal Bit Rate Time Segment 2 Control */
> > + NTSEG1_MASK_ID, /* Nominal Bit Rate Time Segment 1 Control */
> > + NSJW_MASK_ID, /* Nominal Bit Rate Resynchronization Jump Width Control */
> > + DSJW_MASK_ID, /* Data Bit Rate Resynchronization Jump Width Control */
> > + DTSEG2_MASK_ID, /* Data Bit Rate Time Segment 2 Control */
> > + DTSEG1_MASK_ID, /* Data Bit Rate Time Segment 1 Control */
> > + CFTML_MASK_ID, /* Common FIFO TX Message Buffer Link */
> > +};
>
> Please add a common prefix to the enums, i.e. RCANFD_.
OK, will fix this in next version.
Cheers,
Biju
