Hi Niklas,
On Wed, 22 Jan 2025 at 18:27, Niklas Söderlund
<niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> On 2025-01-21 15:49:59 +0100, Geert Uytterhoeven wrote:
> > On Tue, Jan 21, 2025 at 2:59 PM Niklas Söderlund
> > <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> > > Use raw_spinlock in order to fix spurious messages about invalid context
> > > when spinlock debugging is enabled. The lock is only used to serialize
> > > register access.
> > >
> > > [ 4.239592] =============================
> > > [ 4.239595] [ BUG: Invalid wait context ]
> >
> > [...]
> >
> > > [ 4.426274] lock_acquire+0x1c4/0x33c
> > > [ 4.429942] _raw_spin_lock_irqsave+0x5c/0x80
> > > [ 4.434307] gpio_rcar_config_interrupt_input_mode+0x34/0x164
> > > [ 4.440061] gpio_rcar_irq_set_type+0xd4/0xd8
> >
> > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> >
> > Thanks for your patch!
> > This indeed gets rid of the annoying messages on various R-Car boards.
> > Unfortunately I now start seeing other scary messages during resume
> > from s2idle/s2ram.
>
> I think this might be symtom of issues in those drivers too. As Claudiu
> points out the issue in RAVB was discussed and fixed by patch [1].
>
> With this and patch and [1] applied I no longer see a splat when
> resuming on M3N using WoL.
>
> I still think this patch is correct, but of course the bug on Marzen
> should be fixed, but that is unrelated to this patch. Would you agree?
Yes, I think we should proceed with this patch.
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> 1.[PATCH net 1/2] net: ravb: Fix missing rtnl lock in suspend path
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
