Hi Krzysztof, On Tue, Mar 4, 2025 at 6:59 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On 03/03/2025 21:12, Prabhakar wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Add device tree binding document for the Renesas RZ/V2H(P) USB2PHY Control > > Device. It mainly controls reset and power down of the USB2.0 PHY (for > > both host and function). > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > --- > A nit, subject: drop second/last, redundant "bindings". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > OK, I will drop the bindings at the end. > <form letter> > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, instead use mainline) or work on fork of kernel > (don't, instead use mainline). Just use b4 and everything should be > fine, although remember about `b4 prep --auto-to-cc` if you added new > patches to the patchset. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time. > Ouch I missed that, as I sent out a fix to one of the reset driver and re-used the same command. I'll resend the series. Thanks for pointing it out. Cheers, Prabhakar
