Hi Geert Uytterhoeven, > -----Original Message----- > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Sent: 24 February 2025 10:18 > Subject: Re: [PATCH v2 2/2] can: rcar_canfd: Fix page entries in the AFL list > > Hi Biju, > > On Thu, 20 Feb 2025 at 10:45, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > There are a total of 96 AFL pages and each page has 16 entries with > > registers CFDGAFLIDr, CFDGAFLMr, CFDGAFLP0r, CFDGAFLP1r holding the > > rule entries (r = 0..15). > > > > Currently, RCANFD_GAFL* macros use a start variable to find AFL > > entries, which is incorrect as the testing on RZ/G3E shows ch1 and ch4 > > gets a start value of 0 and the register contents are overwritten. > > > > Fix this issue by using rule_entry corresponding to the channel to > > find the page entries in the AFL list. > > > > Fixes: dd3bd23eb438 ("can: rcar_canfd: Add Renesas R-Car CAN FD > > driver") > > Cc: stable@xxxxxxxxxxxxxxx > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > Thanks for your patch! > > I hope to give this a try on White Hawk and Gray Hawk Single, where I never got any channels beyond > the first two to work... Thanks for tying. I guess, on those boards start will get a value "0" for first channel and "1" for second channel like RZ/G2L. Cheers, Biju