Hi Thierry, On Mon, 17 Feb 2025 at 11:54, Thierry Bultel <thierry.bultel.yh@xxxxxxxxxxxxxx> wrote: > In a coming evolution, the registration callback will need more parameters > from cpg_mssr_priv (like another base address with clock controllers > with double register block). > Instead of adding more parameters, mode the needed parameters to a public > sub-struct. No SoB? > drivers/clk/renesas/r7s9210-cpg-mssr.c | 7 +- > drivers/clk/renesas/r8a77970-cpg-mssr.c | 11 +-- > drivers/clk/renesas/rcar-gen3-cpg.c | 8 +- > drivers/clk/renesas/rcar-gen3-cpg.h | 6 +- > drivers/clk/renesas/rcar-gen4-cpg.c | 9 ++- > drivers/clk/renesas/rcar-gen4-cpg.h | 3 +- > drivers/clk/renesas/renesas-cpg-mssr.c | 99 +++++++++++++------------ > drivers/clk/renesas/renesas-cpg-mssr.h | 21 +++++- > 8 files changed, 93 insertions(+), 71 deletions(-) As you forgot to update drivers/clk/renesas/rcar-gen2-cpg.[ch], this breaks the build for R-Car Gen2 and RZ/G1 (e.g. shmobile_defconfig), Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds