On Wed, Feb 12, 2025 at 6:32 PM Fabrizio Castro
<fabrizio.castro.jz@xxxxxxxxxxx> wrote:
>
> Use devm_reset_control_get_exclusive_deasserted() to simplify
> rzg2l_irqc_common_init().
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>
> ---
> drivers/irqchip/irq-renesas-rzg2l.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
Cheers,
Prabhakar
> diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-renesas-rzg2l.c
> index a7c3a3cc6b9f..a29c40466137 100644
> --- a/drivers/irqchip/irq-renesas-rzg2l.c
> +++ b/drivers/irqchip/irq-renesas-rzg2l.c
> @@ -562,14 +562,10 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node *
> return ret;
> }
>
> - resetn = devm_reset_control_get_exclusive(dev, NULL);
> - if (IS_ERR(resetn))
> + resetn = devm_reset_control_get_exclusive_deasserted(dev, NULL);
> + if (IS_ERR(resetn)) {
> + dev_err(dev, "failed to acquire deasserted reset: %d\n", ret);
> return PTR_ERR(resetn);
> -
> - ret = reset_control_deassert(resetn);
> - if (ret) {
> - dev_err(dev, "failed to deassert resetn pin, %d\n", ret);
> - return ret;
> }
>
> pm_runtime_enable(dev);
> @@ -609,7 +605,6 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node *
> pm_runtime_put(dev);
> pm_disable:
> pm_runtime_disable(dev);
> - reset_control_assert(resetn);
> return ret;
> }
>
> --
> 2.34.1
>
>
