Hi Thierry,
On Mon, 10 Feb 2025 at 15:53, Thierry Bultel
<thierry.bultel.yh@xxxxxxxxxxxxxx> wrote:
> On Mon, Feb 10, 2025 at 03:06:29PM +0100, Geert Uytterhoeven wrote:
> > On Wed, 29 Jan 2025 at 17:52, Thierry Bultel
> > <thierry.bultel.yh@xxxxxxxxxxxxxx> wrote:
> > > Add the CPG driver for T2H family.
> > >
> > > Signed-off-by: Thierry Bultel <thierry.bultel.yh@xxxxxxxxxxxxxx>
> >
> > > --- /dev/null
> > > +++ b/drivers/clk/renesas/rzt2h-cpg.c
> > Given RZ/T2 does not use the "write bit 16 + n when touching bit
> > n"-scheme (like RZ/G2L and RZ/V2H), I am wondering if it would be easier
> > to use renesas-cpg-mssr.c instead, like R-Car and RZ/A2M are doing?
>
> Because this is the early support for RZ/T2H CPG, the patch
> does not show the all differences that the driver will have with
> renesas-cpg-mssr.c
> Taking an example, renesas-cpg-mssr.c does not seem to
> handle all the clock types (eg case CLK_TYPE_MUX) that RZ/T2H
> uses. I am just afraid that even if renesas-cpg-mssr.c would
> eventually fit now, significant changes would be required later.
> But you have a wider sight on this than me.
Sure, you will have to add a few new clock types, and a new set of
Module Stop and Module Reset Control Registers.
We'll see. I also don't have a full view on the RZ/T2 internals yet...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
