Hi Geert,
> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 06 February 2025 09:36
> Subject: Re: [PATCH v2 6/8] arm64: dts: renesas: rzg3e-smarc-som: Enable SDHI{0,2}
>
> Hi Biju,
>
> On Fri, 31 Jan 2025 at 12:25, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > Enable eMMC on SDHI0 and SD on SDHI2 on RZ/G3E SMARC SoM.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v1->v2:
> > * Added missing header file gpio.h
> > * Used fixed regulator for eMMC on SD0 and dropped sd0-iovs pins for
> > eMMC.
> > * Sorted pinctrl nodes for sd2
> > * Enabled internal regulator for SD2.
>
> Thanks for the update!
>
> > --- a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> > @@ -7,6 +7,7 @@
> >
> > /dts-v1/;
> >
> > +#include <dt-bindings/gpio/gpio.h>
>
> Not needed in this patch.
>
> > #include <dt-bindings/pinctrl/renesas,r9a09g047-pinctrl.h>
> > #include "r9a09g047e57.dtsi"
> > #include "rzg3e-smarc-som.dtsi"
>
> > --- a/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
>
> > +&vqmmc_sdhi2 {
> > + regulator-name = "SD2_PVDD";
>
> Why override the name?
I just used the label used in RZ/G3E SoM Schematics. So that it appears
as
cat /sys/class/regulator/regulator.4/name
SD2_PVDD
I can revert this change, if needed.
Cheers,
Biju
