Hi Vincent and Sergey, Thanks for the feedback. > -----Original Message----- > From: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx> > Sent: 02 February 2025 08:41 > Subject: Re: [PATCH] can: rcar_canfd: Use of_get_available_child_by_name() > > On 02/02/2025 at 03:52, Sergey Shtylyov wrote: > > On 2/1/25 12:46 PM, Biju Das wrote: > > > >> Simplify rcar_canfd_probe() using of_get_available_child_by_name(). > >> > >> Simplify rcar_canfd_probe() using of_get_available_child_by_name(). > > > > Twice? :-) > > +1 Oops. > > >> While at it, move of_node_put(child) inside the if block to avoid > >> additional check if of_child is NULL. > >> > >> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > [...] > > Please remove the repetition. Aside from that, the patch is good. OK, Will fix and send the next version, when dependency patch hits on net-next. Cheers, Biju
