On Wed, Jan 29, 2025 at 07:31:04PM +0100, Krzysztof Kozlowski wrote: > On 29/01/2025 17:37, Thierry Bultel wrote: > > Document RZ/T2H (a.k.a r9a09g077) in SCI binding. > > A nit, subject: drop second/last, redundant "bindings". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > > And make it anyway shorter. > > > > > Signed-off-by: Thierry Bultel <thierry.bultel.yh@xxxxxxxxxxxxxx> > > --- > > .../bindings/serial/renesas,rzsci.yaml | 100 ++++++++++++++++++ > > 1 file changed, 100 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/serial/renesas,rzsci.yaml > > > > diff --git a/Documentation/devicetree/bindings/serial/renesas,rzsci.yaml b/Documentation/devicetree/bindings/serial/renesas,rzsci.yaml > > new file mode 100644 > > index 000000000000..70e83bbcc79d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/serial/renesas,rzsci.yaml > > @@ -0,0 +1,100 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/serial/renesas,rzsci.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Renesas Serial Communication Interface > > > You are duplicating existing renesas,sci without any explanation. No, > don't. This is pointless. ... and this wasn't tested either. :/ Best regards, Krzysztof
