Hi Biju,
On Tue, 28 Jan 2025 at 11:47, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> The number of GPIO interrupts on RZ/G3E for TINT selection is 141 compared
> to 86 on RZ/V2H. Rename the macro ICU_PB5_TINT->ICU_RZV2H_TSSEL_MAX_VAL to
> hold this difference for RZ/V2H.
>
> Add max_tssel variable to struct rzv2h_hw_info to handle this difference.
>
> Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>
> Reviewed-by: Tommaso Merciai <tommaso.merciai.xr@xxxxxxxxxxxxxx>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> --- a/drivers/irqchip/irq-renesas-rzv2h.c
> +++ b/drivers/irqchip/irq-renesas-rzv2h.c
> @@ -517,6 +518,7 @@ static int rzv2h_icu_init_common(struct device_node *node, struct device_node *p
>
> static const struct rzv2h_hw_info rzv2h_hw_params = {
> .t_offs = 0,
> + .max_tssel = ICU_RZV2H_TSSEL_MAX_VAL,
I am not sure using this ICU_RZV2H_TSSEL_MAX_VAL intermediary brings
much value, compared to the hardcoded constant, as the definition is
used only once. But it looks like Thomas requested this explicitly...
> };
>
> static int rzv2h_icu_init(struct device_node *node, struct device_node *parent)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
