On Mon, Jan 20 2025 at 09:47, Biju Das wrote:
> /**
> * struct rzv2h_hw_info - Interrupt Control Unit controller hardware info structure.
> * @t_offs: TINT offset
> + * @max_tssel: TSSEL max value
> */
> struct rzv2h_hw_info {
> u16 t_offs;
> + u8 max_tssel;
Both the kernel doc and the actual struct members want to be done in
tabular fashion.
https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#struct-declarations-and-initializers
> };
>
> /**
> @@ -298,13 +299,12 @@ static int rzv2h_tint_set_type(struct irq_data *d, unsigned int type)
> return -EINVAL;
> }
>
> + priv = irq_data_to_priv(d);
> tint = (u32)(uintptr_t)irq_data_get_irq_chip_data(d);
> - if (tint > ICU_PB5_TINT)
> + if (tint > priv->info->max_tssel)
> return -EINVAL;
>
> - priv = irq_data_to_priv(d);
> hwirq = irqd_to_hwirq(d);
> -
> tint_nr = hwirq - ICU_TINT_START;
>
> tssr_k = ICU_TSSR_K(tint_nr);
> @@ -514,6 +514,7 @@ static int rzv2h_icu_init_common(struct device_node *node, struct device_node *p
>
> static const struct rzv2h_hw_info rzv2h_hw_params = {
> .t_offs = 0,
> + .max_tssel = 0x55,
See documentation.
Thanks,
tglx
