Hi Philipp, Thanks for the review. > -----Original Message----- > From: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > Sent: 20 January 2025 10:05 > Subject: Re: [PATCH 04/11] irqchip/renesas-rzv2h: Simplify rzv2h_icu_init() > > On Mo, 2025-01-20 at 09:47 +0000, Biju Das wrote: > > Simplify rzv2h_icu_init() by using newly added devm_* helpers. > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > --- > > drivers/irqchip/irq-renesas-rzv2h.c | 15 ++++++--------- > > 1 file changed, 6 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/irqchip/irq-renesas-rzv2h.c > > b/drivers/irqchip/irq-renesas-rzv2h.c > > index fd432b43506b..a02d47529564 100644 > > --- a/drivers/irqchip/irq-renesas-rzv2h.c > > +++ b/drivers/irqchip/irq-renesas-rzv2h.c > > @@ -456,23 +456,23 @@ static int rzv2h_icu_init(struct device_node *node, struct device_node > *parent) > > goto put_dev; > > } > > > > - resetn = devm_reset_control_get_exclusive(&pdev->dev, NULL); > > + resetn = > > +devm_reset_control_get_optional_exclusive_deasserted(&pdev->dev, > > +NULL); > > This changes the reset control to be optional without mentioning it in the commit description. Should > this change be part of another patch? Thanks, It is a typo. It should be devm_reset_control_get_exclusive_deasserted. I will split simplification patches into two in the next version. 1) Adding devm_reset_control_get_exclusive_deasserted() 2) Adding devm_pm_runtime_enable() Cheers, Biju
